547289 - Provide javadoc for org.eclipse.passage.lic.api package #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eparovyshnaya
commented
Oct 23, 2019
eparovyshnaya
commented
- javadoc is added to ConditionTransportRegistry
- since versions are deduced and appended to both ConditionTransport* classes
…i package -- added javadoc for ConditionTransportRegistry Signed-off-by: Elena Parovyshnaia <[email protected]>
…i package -- deduce and append `since` version Signed-off-by: Elena Parovyshnaia <[email protected]>
…i package -- javadoc formatted Signed-off-by: Elena Parovyshnaia <[email protected]>
…i package -- added javadoc for methods parameters Signed-off-by: Elena Parovyshnaia <[email protected]>
…i package -- formatted javadoc Signed-off-by: Elena Parovyshnaia <[email protected]>
ruspl-afed
reviewed
Oct 25, 2019
...e.passage.lic.api/src/org/eclipse/passage/lic/api/conditions/ConditionTransportRegistry.java
Show resolved
Hide resolved
| ConditionTransport getConditionTransportForContentType(String contentType); | ||
|
|
||
| /** | ||
| * Appends the {@code transport} to the <i>registry</i> with the given set of properties. |
There was a problem hiding this comment.
Appends implies some implementation like as the last element of something, maybe in my mind only. But I would prefer to see Adds here.
…i package -- correct wording as requested in code review Signed-off-by: Elena Parovyshnaia <[email protected]>
ruspl-afed
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.